You cannot call savechanges() more than once on a dbcontextscope.

Praveen Kumar

6y1.3k.NET

HI,

I am getting this error when trying to run multiple failed billing.Can any one help me to fix this.

Controller

[HttpPost]
[ValidateAntiForgeryToken]
public async Task ReRunFailedSelectedBilling(List FailedGroups)
{
if (_logger.IsInfoEnabled)
_logger.LogInfo(string.Format("Entering ReRunFailedSelectedBilling"));
List CGs = FailedGroups.Where(x => x.ReRunFlag).ToList();
// Re-using code to get something working for GPSI. This should actually remove all the CGs and then process a single WFR. For now, we'll process one WFR for each CG...
using (var dbContextScope = _dbContextScopeFactory.Create())
{
foreach (BillingFailedViewModel group in CGs)
{
ReRunModel run = new ReRunModel((int)group.Id, DbConnection, ServerURL);
var login = HttpContext.User.Identity.Name;
run.Reject(login);
if (run._Status.Success == false)
{
TempData["Failure"] = "Error in rejection. Failed to reject.";
}
else
{
// Create a new workflow request and re-run
var wfr = run.SetWorkflowRequest();
dbContextScope.SaveChanges();
run.WorkflowRequestId = wfr.Id;
await run.RunAsync(login);
}
}
}
using (var dbContextScope = _dbContextScopeFactory.Create())
{
if (_logger.IsInfoEnabled)
_logger.LogInfo("Exiting ReRunFailedSelectedBilling");
var query = FailedGroups.First().Query;
return RedirectToAction("Billing", "Manage", new { Area = "Billing", CalendarPeriodId = query.CalendarPeriodId, WorkflowGroupId = query.WorkflowGroupId, CompanyId = query.CompanyId, GroupSearch = query.GroupSearch, DisplayBucket = query.DisplayBucket, ShowWorkflowRequests = true });//, calendarPeriodId = FailedGroups.First().QueryPeriodId });
}
}

Model.cs

public async Task RunAsync(string login)
{
logger.LogInfo(string.Format("PERF RunAsync starting"));
// Kick off the server job
string customer = _WfRepo.GetCurrentUserCustomer(_User.WindowsUserName).Customer.Code;
ServiceStatus status = new ServiceStatus { Success = false, Message = "Run failed." };
if (WorkflowRequestId!=null)
{
BusinessActionService.WorkflowRequest request = new BusinessActionService.WorkflowRequest()
{
WorkflowRequestId = WorkflowRequestId.ToString(),
CustomerCode = customer,
UserName = _User.WindowsUserName,
LoginName = login
};
try
{
logger.LogInfo(string.Format("PERF RequestBillingAsync {0} called", WorkflowRequestId.ToString()));
await _Service.RequestBillingAsync(request).ConfigureAwait(false);
}
catch (Exception e)
{
logger.LogError("RequestBilling failed ", e);
}
logger.LogInfo(string.Format("PERF RequestBillingAsync {0} returned", WorkflowRequestId.ToString()));
}
logger.LogInfo(string.Format("PERF RunAsync ending "));
}

5 Replies

Know the answer? Post it — somebody with the same question will find it here.

Jenith Thakkar6y ago
Okay then

using (var dbContextTransaction = dbContextScope.Database.BeginTransaction()) instead of this line write
Type
using (var dbContextTransaction = new TransactionScope()) {

And check is it available or not
Praveen Kumar6y ago
Hi

Using System.data.entity - already declared
Jenith Thakkar6y ago
Please check have you add 'System.Data.Entity' namespace
at the top of page
Praveen Kumar6y ago
Hi Jenith,

I am getting error

After that i added the property like

object Database { get; set; }

Once added property - getting error
Jenith Thakkar6y ago
Use Begin Transaction in that scope
[HttpPost]
[ValidateAntiForgeryToken]
public async Task ReRunFailedSelectedBilling(List FailedGroups)
{
if (_logger.IsInfoEnabled)
_logger.LogInfo(string.Format("Entering ReRunFailedSelectedBilling"));
List CGs = FailedGroups.Where(x => x.ReRunFlag).ToList();
// Re-using code to get something working for GPSI. This should actually remove all the CGs and then process a single WFR. For now, we'll process one WFR for each CG...
using (var dbContextScope = _dbContextScopeFactory.Create())
{
foreach (BillingFailedViewModel group in CGs)
{
ReRunModel run = new ReRunModel((int)group.Id, DbConnection, ServerURL);
var login = HttpContext.User.Identity.Name;
run.Reject(login);
if (run._Status.Success == false)
{
TempData["Failure"] = "Error in rejection. Failed to reject.";
}
else
{
// Create a new workflow request and re-run
using (var dbContextTransaction = dbContextScope.Database.BeginTransaction())
{
try
{
var wfr = run.SetWorkflowRequest();
dbContextScope.SaveChanges();
dbContextTransaction.Commit();
run.WorkflowRequestId = wfr.Id;
await run.RunAsync(login);
}
catch(Exception ex)
{
}
}
}
}
}
using (var dbContextScope = _dbContextScopeFactory.Create())
{
if (_logger.IsInfoEnabled)
_logger.LogInfo("Exiting ReRunFailedSelectedBilling");
var query = FailedGroups.First().Query;
return RedirectToAction("Billing", "Manage", new { Area = "Billing", CalendarPeriodId = query.CalendarPeriodId, WorkflowGroupId = query.WorkflowGroupId, CompanyId = query.CompanyId, GroupSearch = query.GroupSearch, DisplayBucket = query.DisplayBucket, ShowWorkflowRequests = true });//, calendarPeriodId = FailedGroups.First().QueryPeriodId });
}
}
please replace your ReRunFailedSelectedBilling method to this method and check