asp.net core validate a bool value

C# Corner

13 Replies

Know the answer? Post it — somebody with the same question will find it here.

Kiran Mohanty5y ago
Accepted answer
Hi,
You can always keep a check manually like
bool expctedBoolValue = true; //based on page it is either true or false. this value should be passed or stored somewhere


if(model.BoolProperty != expctedBoolValue){
    ModelState.AddModelError("key", errorMessage);
return View();
}
Marius Vasile5y ago
Got it, I believe I repeat this mistake, maybe I will remember not to. The error came from:
for="WOPlanner.SOPAvailable" type="checkbox" data-width="200" data-toggle="toggle" data-on="Yes" data-off="No" data-onstyle="success" data-offstyle="primary" value="@Model.WOPlanner.SOPAvailable" />
value should not be there because the data is already binded to the model. I removed the value from all bool input and is working fine
Marius Vasile5y ago
If I use
editPlanner.SOPAvailable = true;
await _context.SaveChangesAsync();
it works, bool is updated but the other way it does not
Kiran Mohanty5y ago
Very Odd
Marius Vasile5y ago
the if is being executed because text values are updated
a => a.Tools,
                    a => a.ToolsAvailable,
                    a => a.Expertise,
                    a => a.ExpertiseAvailable,
                    a => a.Parts,
                    a => a.PartsAvailable,
                    a => a.SOPs,
                    a => a.SOPAvailable
Tools, Expertise, Parts and SOPs are text and they are updated everytime. Boolean values are updated only from true to false but not from false to true
Kiran Mohanty5y ago
Probably the if block is not being executed. May be any of the property has validation error. (Just a guess) Can you please keep a else block with ModelState.ValidationErrors, to see if model has nay invalid data?
Marius Vasile5y ago
In a previous step I set those bool values, either true or false and their are saved properly. In this subsequent step, the user should be able to update data including bool values if equipment, parts, etc become available. I want to prevent post if not all bool values are true but with that procedure, only the text values or false bool are saved
Kiran Mohanty5y ago
Can you please verify those property values are true before saving ? Do you have any specific logic to not update those fields ?
Marius Vasile5y ago
This is the procedure
public async Task OnPostWOScheduleAsync(string womainid)
        {
            var woplanner = await _context.WOPlanners.Where(s => s.WOMainID == womainid).Select(s => s.WOPlannerId).FirstOrDefaultAsync();
            var editPlanner = await _context.WOPlanners.FindAsync(woplanner);

            if (await TryUpdateModelAsync(editPlanner, "WOPlanner",
                    a => a.Tools,
                    a => a.ToolsAvailable,
                    a => a.Expertise,
                    a => a.ExpertiseAvailable,
                    a => a.Parts,
                    a => a.PartsAvailable,
                    a => a.SOPs,
                    a => a.SOPAvailable
                ))
            {
                    await _context.SaveChangesAsync();
                    return RedirectToPage("/WO/WOForm", new { woS = womainid, error = 1 });
            }
ToolsAvailable, ExpertiseAvailable, PartsAvailable and SOPAvailable are all bool values
Kiran Mohanty5y ago
Which boolean value are you trying to update ? in your latest thread, can you please highlight it.
Marius Vasile5y ago
Actually I was able to save all bool values as false but none as true when I tried
Marius Vasile5y ago
The problem I have now is that the bool value does not update when use
public async Task OnPostWOScheduleAsync(string womainid)
        {
            var woplanner = await _context.WOPlanners.Where(s => s.WOMainID == womainid).Select(s => s.WOPlannerId).FirstOrDefaultAsync();
            var editPlanner = await _context.WOPlanners.FindAsync(woplanner);

            if (await TryUpdateModelAsync(editPlanner, "WOPlanner",
                    a => a.Tools,
                    a => a.ToolsAvailable,
                    a => a.Expertise,
                    a => a.ExpertiseAvailable,
                    a => a.Parts,
                    a => a.PartsAvailable,
                    a => a.SOPs,
                    a => a.SOPAvailable
                ))
            {

                    await _context.SaveChangesAsync();



            }
but other fields are updated. what is wrong?
Marius Vasile5y ago
Thank you Kiran, the idea was good. The code looks like below
var editPlanner = await _context.WOPlanners.SingleOrDefaultAsync(s => s.WOMainID == womainid);
            if (await TryUpdateModelAsync(editPlanner, "WOPlanner",
                    a => a.ToolsAvailable,
                    a => a.ExpertiseAvailable,
                    a => a.PartsAvailable,
                    a => a.SOPAvailable
                ))
            {
                bool boolValue = true;
                if (editPlanner.ToolsAvailable == boolValue && editPlanner.ExpertiseAvailable == boolValue && editPlanner.PartsAvailable == boolValue && editPlanner.SOPAvailable == boolValue)
                {
                    await _context.SaveChangesAsync();
                }
                else
                {
                    var error = 1;
                    return RedirectToPage("/WO/WOForm", new { womainid = womainid, error });
                }
            }