Display the minimum answer

Ms Lyana

9y1kVisual Basic .NET

Hi, I have problem to display my minimum value from the answer that I got.

Here is my output when I run :

The problem is, at the minimum result it shows nothing. Supposely it will show like this

9 7 6 =2

because that is the minimum value (2).

Here is my code:

class Program
{
static void Main(string[] args)
{
string input;
int NoDisplay;
decimal goal;
decimal element;
do
{
Console.WriteLine("Please enter the target:");
input = Console.ReadLine();
}
while (!decimal.TryParse(input, out goal));
Console.WriteLine("Please enter the numbers (separated by spaces)");
input = Console.ReadLine();
string[] elementsText = input.Split(' ');
List elementsList = new List();
foreach (string elementText in elementsText)
{
if (decimal.TryParse(elementText, out element))
{
elementsList.Add(element);
}
}
int i;
int j;
decimal tmp;
for (i = 0; i < elementsList.Count; i++)
{
for (j = i + 1; j < elementsList.Count; j++)
{
if (elementsList[i] < elementsList[j])
{
tmp = elementsList[i];
elementsList[i] = elementsList[j];
elementsList[j] = tmp;
}
}
}
Console.WriteLine("Please enter the maximum combination :");
NoDisplay = Convert.ToInt32(Console.ReadLine());
Console.WriteLine("The results is :"); //the first result
Solver solver = new Solver();
List> results = solver.Solve(goal, elementsList.ToArray());
//results.Reverse();
int counter = 0;
Boolean recordexist = false;
foreach (List result in results)
{
if (counter == 3) break;
if (result.Count == NoDisplay)
{
decimal sum = 0;
recordexist = true;
foreach (decimal value in result)
{
Console.Write("{0}\t", value);
sum = sum + value;
}
if (recordexist == true)
{
Console.WriteLine(" = " + sum);
}
counter++;
}
}
if (recordexist == false)
{
Console.WriteLine("No record exist");
}
Console.WriteLine("The final results is :"); //the last result
Solver solvers = new Solver();
List> resultss = solvers.Solve(goal, elementsList.ToArray());
//results.Reverse();
int counters = 0;
Boolean recordexists = false;
decimal minSub = 0; //to holding minimun total
List minResult = new List(); //to holding minimum Result
foreach (List result in results)
{
if (counters == 3) break;
if (result.Count == NoDisplay)
{
decimal subtract = 0;
decimal sum = 0;
recordexists = true;
foreach (decimal value in result)
{
Console.Write("{0}\t", value);
sum = sum + value;
subtract = sum - goal;
}
if (subtract < minSub)
{
minSub = subtract;
foreach (decimal value in result)
{
minResult.Add(value);
}
}
if (recordexists == true)
{
Console.WriteLine(" = " + subtract);
}
counters++;
}
}
if (recordexists == false)
{
Console.WriteLine("No record exist");
}
Console.WriteLine("The minimum results is :"); //the minimum result line
foreach (decimal value in minResult)
{
Console.Write("{0}", minSub);
}
Console.ReadLine();
}
}

Thanks in advance

8 Replies

Know the answer? Post it — somebody with the same question will find it here.

Dharmraj Thakur9y ago
Accepted answer
See I have corrected code....
decimal minSub = 0;     //to holding minimun total
            List<decimal> minResult = new List<decimal>(); //to holding minimum Result
            foreach (List result in results)
            {

                if (counters == 3) break;
                if (result.Count == NoDisplay)
                {
                    decimal subtract = 0;
                    decimal sum = 0;
                    recordexists = true;
                    foreach (decimal value in result)
                    {

                        Console.Write("{0}\t", value);
                        sum = sum + value;
                        subtract = sum - goal;
                    }


                    if (subtract < minSub)
                    {
                        minSub = subtract;
                        foreach (decimal value in result)
                        {
                            minResult.RemoveAll();
                            minResult.Add(value);
                        }
                    }

                    if (recordexists == true)
                    {

                        Console.WriteLine(" = " + subtract);
                    }

                    counters++;

                }
            }


            if (recordexists == false)
            {
                Console.WriteLine("No record exist");
            }

            Console.WriteLine("The minimum results is :");   //the minimum result line
            foreach (decimal value in minResult)
            {

                Console.Write("{0}", value);
            }
            Console.WriteLine(" = {0}", minSub);   //the minimum result line
Still getting error? I found some mistakes in your code.... If this is not resolve then show give me your runnble code....
Ms Lyana9y ago
@Dharmraj Thakur this is my solver class sir.
public class Solver
   {

       private List> mResults;

       public List> Solve(decimal goal, decimal[] elements)
       {

           mResults = new List>();

           RecursiveSolve(goal, 0.0m,
               new List(), new List(elements), 0);
           return mResults;
       }


       private void RecursiveSolve(decimal goal, decimal currentSum,
           List included, List notIncluded, int startIndex)
       {

           for (int index = startIndex; index < notIncluded.Count; index++)
           {

               decimal nextValue = notIncluded[index];
               if (currentSum + nextValue > goal) //bigger than target
               {

                   List newResult = new List(included);
                   newResult.Add(nextValue);
                   mResults.Add(newResult);


               }

               else if (currentSum + nextValue < goal)
               {

                   List nextIncluded = new List(included);
                   nextIncluded.Add(nextValue);
                   List nextNotIncluded = new List(notIncluded);
                   nextNotIncluded.Remove(nextValue);
                   RecursiveSolve(goal, currentSum + nextValue,
                       nextIncluded, nextNotIncluded, startIndex++);
               }


           }

       }

   }
I already put in my previous code
Dharmraj Thakur9y ago
There is no any Solver class... it also need to run...
Dharmraj Thakur9y ago
You have to give me full runnable code
Ms Lyana9y ago
@Dharmraj Thakur I only got 2 if I change this
decimal minSub = 100; //to holding minimun total
I change to 100 instead of 0. But I know its gonna be wrong. I need to create an array for answer that I already subtract right?
Here my output that I get when I change it to 100
Ms Lyana9y ago
@Dharmraj Thakur i got like this sir
why it show 0?
Dharmraj Thakur9y ago
Ohkay... Try this...
if (subtract < minSub)
{
    minSub = subtract;
    foreach (decimal value in result)
    {
        minResult=null;
        minResult = new List<decimal>();
        minResult.Add(value);
    }
}
Ms Lyana9y ago
@Dharmraj Thakur I got error at "minResult.RemoveAll();" it shows " There is no argument given that corresponds to the required formal parameter 'match' of 'List.RemoveAll(Predicate)' "