Generate new id code with alpha and number format

I create c# project with Access Database and I want to Autogenerated new id (Format as 3 Alphabets 3 Digits) but alphabets change automatically with selection of last form. i tried this but just 1st condition works,

void NewAppID()
{
try
{
OleDbDataAdapter da = new OleDbDataAdapter("select [FormCode] from [Booking] order by [FormCode] desc", conn);
DataSet ds = new DataSet();
da.Fill(ds);
if (lblProName.Text == "Fazal Sun City" || ds.Tables[0].Rows.Count > 0)
{
txtFormCode.Text = "FSC " + (int.Parse(ds.Tables[0].Rows[0][0].ToString()) + 1).ToString();
}
else if (lblProName.Text == "Mehran Gold" || ds.Tables[0].Rows.Count > 0)
{
txtFormCode.Text = "MG " + (int.Parse(ds.Tables[0].Rows[0][0].ToString()) + 1).ToString();
}
else
{
txtFormCode.Text = "1";
}
}
catch (Exception ex)
{
MetroFramework.MetroMessageBox.Show(this, "Error" + ex.Message, "Stop", MessageBoxButtons.OK, MessageBoxIcon.Stop);
}
}

As far as I've understood your code, there's a minor logical issue. you're using || operator which means that the statement will be true if either of the two conditions are true (simple definition of OR operation). In your case

if (lblProName.Text == "Fazal Sun City" || ds.Tables[0].Rows.Count > 0)

Will always be true as long as you have some data in your first dataTable and so only first condition will work. Else part will never be evaluated. One way to fix this problem is to use nested if and omit OR.

void NewAppID()
{
try
{
OleDbDataAdapter da = new OleDbDataAdapter("select [FormCode] from [Booking] order by [FormCode] desc", conn);
DataSet ds = new DataSet();
da.Fill(ds);
if (ds.Tables[0].Rows.Count > 0) {
if (lblProName.Text == "Fazal Sun City")
{
txtFormCode.Text = "FSC " + (int.Parse(ds.Tables[0].Rows[0][0].ToString()) + 1).ToString();
}
else if (lblProName.Text == "Mehran Gold")
{
txtFormCode.Text = "MG " + (int.Parse(ds.Tables[0].Rows[0][0].ToString()) + 1).ToString();
}
else
{
txtFormCode.Text = "1";
}
}
}
catch (Exception ex)
{
MetroFramework.MetroMessageBox.Show(this, "Error" + ex.Message, "Stop", MessageBoxButtons.OK, MessageBoxIcon.Stop);
}
}

Hope that helps.

1 Reply

Know the answer? Post it — somebody with the same question will find it here.

Mehreen Tahir7y ago
As far as I've understood your code, there's a minor logical issue. you're using || operator which means that the statement will be true if either of the two conditions are true (simple definition of OR operation). In your case
if (lblProName.Text == "Fazal Sun City" || ds.Tables[0].Rows.Count > 0)
Will always be true as long as you have some data in your first dataTable and so only first condition will work. Else part will never be evaluated. One way to fix this problem is to use nested if and omit OR.
void NewAppID()
        {
            try
            {
                OleDbDataAdapter da = new OleDbDataAdapter("select [FormCode] from [Booking] order by [FormCode] desc", conn);
                DataSet ds = new DataSet();
                da.Fill(ds);
  if (ds.Tables[0].Rows.Count > 0) {
                    if (lblProName.Text == "Fazal Sun City")
                        {
                                txtFormCode.Text = "FSC " + (int.Parse(ds.Tables[0].Rows[0][0].ToString()) + 1).ToString();
                        }
                    else if (lblProName.Text == "Mehran Gold")
                         {
                                txtFormCode.Text = "MG " + (int.Parse(ds.Tables[0].Rows[0][0].ToString()) + 1).ToString();
                         }
                    else
                        {
                                txtFormCode.Text = "1";
                        }
}

            }
            catch (Exception ex)
            {
                MetroFramework.MetroMessageBox.Show(this, "Error" + ex.Message, "Stop", MessageBoxButtons.OK, MessageBoxIcon.Stop);
            }
        }
Hope that helps.