How to stop a loop when its the end of database

Israel

Hi!

With these codes its making a loop. But the problem is its displaying the record into combobox until the last record of my dababase. But later this work its doesnt stop. Its sound making the loop without stop. I have to stop it manually because with the exit button its doesnt stop:

OleDbConnection con = new OleDbConnection(@"Provider=Microsoft.Jet.OLEDB.4.0;Data Source=C:\BlessFive\BlessFive\App_Datas\blessfive.mdb;Persist Security Info=False");

con.Open();

OleDbCommand cmd = new OleDbCommand("select numbers from Receive_Numbers_To_Send", con);

OleDbDataAdapter SDA = new OleDbDataAdapter();

SDA.SelectCommand = cmd;

DataTable DT = new DataTable();

SDA.Fill(DT);

cbxSMSSending.DataSource = DT;

con.Close();

Application.DoEvents();

ia++;

int milliseconds = 2000;

Thread.Sleep(milliseconds);

//button6.PerformClick();

//btnEnvoiSMS_PrincipalEntry.PerformClick(); //Trigger click event

//btnAffiche.PerformClick();

9 Replies

Know the answer? Post it — somebody with the same question will find it here.

Israel9y ago
When I said "loop". I would like to say that its still doing the same "circle" reading those numbers sent to my combobox without stop. Its could stop when its finish to read the latest record. But its doesnt. This "circle" as I called "loop" should be on the timer.
I think that the problem should be on this code. Because its buggs and doenst allow me even to click to any button (for example on "exit") :
con.Open();
OleDbCommand cmd = new OleDbCommand("select numbers from Receive_Numbers_To_Send", con);
OleDbDataAdapter SDA = new OleDbDataAdapter();
SDA.SelectCommand = cmd;
DataTable DT = new DataTable();
SDA.Fill(DT);
cbxSMSSending.DataSource = DT;
con.Close();
Application.DoEvents();
ia++;
int milliseconds = 2000;
Thread.Sleep(milliseconds);
Amit Gupta9y ago
Unfortunately I am not with my system, so I am unable to help you with the code currently. Just try to modify the code, when you stuck any where in between then do let me know
Israel9y ago
@Amit
Thank you for your good advices.I dont ask to resolv all of the codes. Even its badly writed as yo said. But I need a help to resolv this problem. Its doesnt stop when its arrived at the last record. Thank you.
Rafnas T P9y ago
hi,
can you post where is your loop, and why are you looping
Amit Gupta9y ago
Hey

Your code is running in an recursive process thats causes unresponsive of your UI. I cannot do the complete code for you but doing some changes will definetly increase your application performance.

1. Use seperate methods for binding your data and for sending the messages.
2. DO NOT use any recursive function in it, it will be infinite until the program gets terminated.
3. To send sms to multiple users, use a for loop that runs at a max of your combobox items count.

Improve Code Quality
1. Use a seperate centralized code for data access
2. Avoid using Connection string multiple times, use it once and call it multiple times

This will also make your code clean and easy to maintain.

Good Luck!!
Israel9y ago
To give a good understanding.
I do send the zip of my program. What its should:
1. There two smal table: Fill_Numbers and Receive_numbers_to_send
2. The new records are send into Fill_Numbers table then those records can be send later to send to Receive_numbers_to_send with then with the data transfert button named btnTransfertDonnees_PrincipalEntry in code
3. When you click on SMS to send button named in code btnEnvoiSMS_PrincipalEntry. Its will displaying into combobox.
4. Some time the sending process sound slow and later its shows this message: "the time limits of the operation went reaching"
5. The very big problem is after all this process its blocks and even the exit button doesnt work any more
Gokhul Varman9y ago
It is very simple just learn some basic queries for more explanation refer the link:https://stackoverflow.com/questions/40600873/how-to-stop-loop-in-while-statement-in-php-mysql
Amit Gupta9y ago
Where is the loop? Avoid using Thread.Sleep, as it blocks yoir UI thread for 2 seconds
Sundaram Subramanian9y ago
Kindly use break in loop, when the datasource or datatable values is null.