I have 2.75 million buttons - Do I need do create a new Button_click() for each button?

Tomas Westerlund

Hi,
I am creating a small game where you can buy animals, food etc.

I have a class for the animals as well as the food and you can buy food through the buttons (a "+" and a "-" button) and the same with the food.

However I have ~10 animals and the buttons to the same thing (based on the set property). Do I need to create a new Button_Click for each button?

Here is the code for one button for example:

private void penguinSub_Click(object sender, EventArgs e)

{

if (Penguin.Amount > 0)

{

Penguin.Amount -= 1;

money = money + (int)(Convert.ToDouble(Penguin.Cost * 0.9));

reloadLabels();

}

Also the Tiger_Button will do the exactly same thing but lower Tiger.Amount instead of Penguin.Amount (and so forth).

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Tomas Westerlund15y ago
Thanks for the answers! I am creating a method for each button right now, however I am going to show you the code when I am done and it gets very "blurry". Best regards, Tomas
Vulpes15y ago
You don't have to create a button click eventhandler for each button. You can use a single eventhandler for them by creating a handler for the first button (as below) and then wiring up the Click event for all the other buttons to this handler by selecting it from the dropdown in the Properties box for those buttons.

However, you will need to set up a Dcitionary to associate buttons with their corresponding Animal objects, so it might be more trouble than it's worth:

private Dictionary dict;

private Form1_Load(object sender, EventArgs e)
{
// existing code
dict = new Dictionary();
dict.Add(penguinSub, Penguin);
dict.Add(Tiger_Button, Tiger);
// etc
}

private void animalButton_Click(object sender, EventArgs e)
{
Animal animal = dict[(Button)sender];

if (animal.Amount > 0)
{
animal.Amount -= 1;
money = money + (int)(Convert.ToDouble(animal.Cost * 0.9));
reloadLabels();
}

}
Suthish Nair15y ago
Search for Event Handling in C#
Tomas Westerlund15y ago
Also, the Class already have a property to set the buttons as well:

//Sets the amount label (How many of this animal that exists)
private Label amountLabel;
public Label AmountLabel
{
get { return amountLabel; }
set { amountLabel = value; }
}

//The button adds or substracts an animal!
private Button buttonAdd;
public Button ButtonAdd
{
set { amount += 1; }
}
private Button buttonSub;
public Button ButtonSub
{
set { amount -= 1; }
}