Login Form , Facing A Problem

Arslan Ali

Hi , I Am Creating A LOGIN FORM For My new Project , But The Query Seems To Generate The Error , Please Check

con.Open();

string txtUser = txtUserName.Text;

string txtPwd = txtPassword.Text;

//SqlCommand getuserinfo = new SqlCommand("SELECT * FROM tbl_admin WHERE user '" + txtUser + "' AND password '" + txtPwd + "'", con);

SqlCommand getuserinfo = new SqlCommand("SELECT * FROM tbl_admin WHERE user ", con);

using (SqlDataReader dr = getuserinfo.ExecuteReader())

{

while (dr.Read())

{

if ((dr["user"].ToString() == txtUserName.Text) && (dr["password"].ToString() == txtPassword.Text))

{

MessageBox.Show("Login Successful !", "Login", MessageBoxButtons.OK, MessageBoxIcon.Information);

}

else

{

MessageBox.Show("Access Denied !", "Login", MessageBoxButtons.OK, MessageBoxIcon.Error);

txtUserName.Text = "";

txtPassword.Text = "";

txtUserName.Focus();

}

con.Close();

}

catch (SqlException se)

{

MessageBox.Show(se.ToString());

}

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Nitin Sontakke8y ago
Accepted answer
Can you not show us the error? Wouldn't that be helpful / easy in resolving your issue?

In your commented query there is no = and in your uncommented query you have not completed the where clause at all. Looking at your code, I am not sure if you already know basic SQL or not. If not, I suggest you either google or keep a book handy or complete one of the very basic SQL courses available online absolutely free of charge.

Your first, commented out query should be as follows:
SqlCommand getuserinfo = new SqlCommand("SELECT * FROM tbl_admin WHERE [user] = '" + txtUser + "' AND [password] = '" + txtPwd + "'", con);
Tarique Sultan8y ago
select query must be as "Select top 1 user,password from tbl_admin where user= and password=", this query will give you one result as User="Something" and Password="Something" and store the result into some self created variable and then make comparison, I'm sure, your problem will be resolved.

you are unnecessarily trying to fetch more than one records from database.