My new form is being closed automatically

Tomas Westerlund

14y2.2kVisual Basic .NET

Hi,
This is from my mainForm:

private void buttonAdd_Click(object sender, EventArgs e)

{

//New ContactForm

ContactForm contactForm = new ContactForm();

}

The ContactForm opens and then I fill in some data and I press the button called Add:

private void buttonAddContact_Click(object sender, EventArgs e)

{

bool isDataOk = false;

isDataOk = contact.AddAddress(textBoxFirstName.Text,

textBoxLastName.Text,

textBoxPhoneHome.Text,

textBoxPhoneCell.Text,

textBoxEmailPrivate.Text,

textBoxEmailBusiness.Text,

textBoxStreet.Text,

textBoxCity.Text,

textBoxZipcode.Text,

comboBoxCountries.Text);

}

And now my Form closes which seems to be logical. However I want that when isDataOk = false (i.e. the input data doesn't look 100%) it should now close.

I'm not sure where and how I should put this. Can anyone please assist me in this?

Best regards,
Tomas

5 Replies

Know the answer? Post it — somebody with the same question will find it here.

Vulpes14y ago
Accepted answer
Well, I take it that buttonAddContact_Click is an event handler on the ContactForm and the latter is being closed by the user (pressing say the X button) rather than anything you're doing programatically.

If that's so, then I'd make isDataOk a private field rather than a local variable and handle ContactForm's FormClosing event as follows:

private bool isDataOk = false; // now a field

private void buttonAddContact_Click(object sender, EventArgs e)
{

isDataOk = contact.AddAddress(textBoxFirstName.Text,
textBoxLastName.Text,
textBoxPhoneHome.Text,
textBoxPhoneCell.Text,
textBoxEmailPrivate.Text,
textBoxEmailBusiness.Text,
textBoxStreet.Text,
textBoxCity.Text,
textBoxZipcode.Text,
comboBoxCountries.Text);
}

private void Form1_FormClosing(Object sender, FormClosingEventArgs e)
{
if(!isDataOk)
{
MessageBox.Show("There are some errors in the input data. Please correct");
e.Cancel = true; // prevent form from closing
}
}
Tomas Westerlund14y ago
I'm sorry. I lost my brain for a minute. Of course it's that simple!

For other people:
* Choose the form in the designer
* FormClosing exists under "Events" just select it and double-click

Thanks!
Tomas Westerlund14y ago
Hi,
I don't get it really. How and when will Form1_FormClosing be executed?

Best regards,
Tomas
Vulpes14y ago
Handling the Form_Closing event in the way I described, will still prevent the form from being closed manually by the user until the input data is satisfactory.

If your CheckDate method is closing the form programatically then, of course, you can refrain from doing so if the data is not OK.
Tomas Westerlund14y ago
Hi,
When I click the buttonAddContact_Click all the checks are done my a method called CheckDate in contact.AddAddress.CheckData.

If anything looks bad an mbox popups with the problem. So if the data is _not_ ok I would like the user to able to continue with his form i.e. I don't want the ContactForm to be closed if there is any problem with the formatting.

Best regards,
Tomas