Need to loop through names in table and send all an email

//-----------------

//Hi Ali, It wasn't looping through the MailMessage properly, now it puts each email address into the string variable 'emailnew', then adds it to the MailMessage 'message.To.Add(emailnew)' and sends the email one at a time using 'smtpClient.Send(message);'. It appears to be in the right order now. Thanks Heaps for your Help Ali, I really appreciate it.

//Trying8.aspx - Finally Works, it sends LINE STOP Email to every SuppEmail recipient in Suppliers Table

<%@ Page Language="C#" AutoEventWireup="true" CodeBehind="Trying8.aspx.cs" Inherits="SpecCars.Admin.Trying8" %>

//-----------------

//Trying8.aspx.cs - Finally Works, it sends LINE STOP Email to every SuppEmail recipient in Suppliers Table

using System;
using System.Collections.Generic;
using System.Data;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Net;
using System.Net.Mail;
using System.Text;

namespace SpecCars.Admin
{
  public partial class Trying8 : System.Web.UI.Page
  {
    protected void Page_Load(object sender, EventArgs e)
    {

    }

    protected void Button1_Click(object sender, EventArgs e)
    {

      SqlDataReader sqlData;
      SqlConnection connection = new SqlConnection("Data Source=.;Initial Catalog=SpecCars;Integrated Security=True");
      connection.Open();

      sqlData = new SqlCommand("Select * From Suppliers", connection).ExecuteReader();
      using (SmtpClient smtpClient = new SmtpClient("smtp-mail.provider.com", 587))
      {
        while (sqlData.Read())
        {
          string emailnew = sqlData["SuppEmail"].ToString();
          Label1.Text = emailnew.ToString();

          using (MailMessage message = new MailMessage())
          {
            try
            {
              message.From = new MailAddress("[email protected]");
              // This doesn't Send (To:) [email protected]
              MailAddress AddressTo = new MailAddress("[email protected]");
     // This does Send (To:) to SuppEmail recipient in Suppliers Table
              message.To.Add(emailnew);
              //This does Send a (CC:) [email protected]
              message.CC.Add("[email protected]");
              message.Subject = "Assembly Line Stop";
              message.Priority = MailPriority.High;

              message.Body = "Please be advised that the assembly line at Specialised Cars has STOPPED. You will be notified once the line has started again. Any Services between the LINE STOP and the LINE START will be carried out after 19:00 (7pm).";
              message.IsBodyHtml = true;

              smtpClient.EnableSsl = true;
              smtpClient.Credentials = new System.Net.NetworkCredential("[email protected]", "password");
              smtpClient.Send(message);
              // smtpClient.Dispose();
              // message.Dispose();
            }
            catch (Exception ex)
            {
              //log exceptions here, you can write it to a txt file, or to a label in your form for testing purpose
              //we are trying to see if you get an exception..
              Label1.Text = ex.Message;
            }
          }
        }
      }

    }
  }
}

//-----------------
 

-----------------

Hi All,  just a quick update:

Trying8.aspx - Finally Works, it sends LINE STOP Email to every SuppEmail recipient in Suppliers Table

<%@ Page Language="C#" AutoEventWireup="true" CodeBehind="Trying8.aspx.cs" Inherits="SpecCars.Admin.Trying8" %>

-----------------

EntCar.aspx.cs - Finally Works, it sends LINE STOP Email to every SuppEmail recipient in Suppliers Table

using System;
using System.Collections.Generic;
using System.Data;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Net;
using System.Net.Mail;
using System.Text;

namespace SpecCars.Admin
{
  public partial class Trying8 : System.Web.UI.Page
  {
    protected void Page_Load(object sender, EventArgs e)
    {

    }

    protected void Button1_Click(object sender, EventArgs e)
    {

      SqlDataReader sqlData;
      SqlConnection connection = new SqlConnection("Data Source=.;Initial Catalog=SpecCars;Integrated Security=True");
      connection.Open();

      sqlData = new SqlCommand("Select * From Suppliers", connection).ExecuteReader();
      using (SmtpClient smtpClient = new SmtpClient("smtp-mail.provider.com", 587))
      {
        while (sqlData.Read())
        {
          string emailnew = sqlData["SuppEmail"].ToString();
          Label1.Text = emailnew.ToString();

          using (MailMessage message = new MailMessage())
          {
            try
            {
              message.From = new MailAddress("[email protected]");
              // This doesn't Send (To:) [email protected]
              MailAddress AddressTo = new MailAddress("[email protected]");
              // This does Send (To:) [email protected]
              // message.To.Add("[email protected]");
              // This does Send (CC:) to SuppEmail recipient in Suppliers Table
              message.CC.Add(emailnew);
              message.Subject = "Assembly Line Stop";
              message.Priority = MailPriority.High;

              message.Body = "Please be advised that the assembly line at Specialised Cars has STOPPED. You will be notified once the line has started again. Any Services between the LINE STOP and the LINE START will be carried out after 19:00 (7pm).";
              message.IsBodyHtml = true;

              smtpClient.EnableSsl = true;
              smtpClient.Credentials = new System.Net.NetworkCredential("[email protected]", "password");
              smtpClient.Send(message);
              // smtpClient.Dispose();
              // message.Dispose();
            }
            catch (Exception ex)
            {
              //log exceptions here, you can write it to a txt file, or to a label in your form for testing purpose
              //we are trying to see if you get an exception..
              Label1.Text = ex.Message;
            }
          }
        }
      }

    }
  }
}

-----------------
 

You could try asynchronous mail:

Ali, Here is the code. With Dispose it still sends only one email and I put the Error in a Label - Cannot access a disposed object. Object name: 'System.Net.Mail.SmtpClient'.
If I don't use Dispose, it throws no Errors and still sends only one email.

using System;
using System.Collections.Generic;
using System.Data;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Net;
using System.Net.Mail;
using System.Text;

namespace SpecCars.Admin
{
  public partial class Trying3 : System.Web.UI.Page
  {
    protected void Page_Load(object sender, EventArgs e)
    {

    }

    protected void Button1_Click(object sender, EventArgs e)
    {

      SqlDataReader sqlData;
      SqlConnection connection = new SqlConnection("Data Source=.;Initial Catalog=SpecCars;Integrated Security=True");
      connection.Open();
      sqlData = new SqlCommand("Select SuppEmail From Suppliers", connection).ExecuteReader();
      using (SmtpClient smtpClient = new SmtpClient("smtp-mail.provider.com", 587))
      {
        while (sqlData.Read())
        {
          using (MailMessage message = new MailMessage())
          {
            try
            {
              string emailnew = sqlData["SuppEmail"].ToString();
              message.From = new MailAddress("myemail.com");
              message.To.Add(emailnew);
              MailAddress AddressTo = new MailAddress("myemail.com");
              message.To.Add("myemail.com");
              //add rest of your code here
              message.Subject = "Assembly Line Stop";
              message.Priority = MailPriority.High;

              message.Body = "Please be advised.";
              message.IsBodyHtml = true;

              smtpClient.EnableSsl = true;
              smtpClient.Credentials = new System.Net.NetworkCredential("mymail.com", "password");
              smtpClient.Send(message);
              smtpClient.Dispose();
              message.Dispose();
            }
            catch (Exception ex)
            {
              //log exceptions here, you can write it to a txt file, or to a label in your form for testing     purpose
              //we are trying to see if you get an exception..
              Label1.Text = ex.Message;
            }
          }
        }
      }

    }
  }
}

 

Hi Charles, I think you should be getting exception, if you don't, might be something wrong with email address, did you try different addresses?

SqlDataReader sqlData;
SqlConnection connection = new SqlConnection("Data Source=.;Initial Catalog=SpecCars;Integrated Security=True");
connection.Open();
sqlData = new SqlCommand("Select SuppEmail From Suppliers", connection).ExecuteReader();
using (SmtpClient smtpClient = new SmtpClient())
{
    while (sqlData.Read())
    {
         using (MailMessage message = new MailMessage())
         {
             try
             {
               string emailnew = sqlData["SuppEmail"].ToString();
                 message .From = new MailAddress("myemail.com");
                 message.To.Add(emailnew);
    //add rest of your code here
                 smtpClient.EnableSsl = true;
           smtpClient.Credentials = new System.Net.NetworkCredential("myemail.com", "password");
                 smtpClient.Send(mailMessage)
              }
              catch (Exception ex)
              {
                  //log exceptions here, you can write it to a txt file, or to a label in your form for testing     purpose
                  //we are trying to see if you get an exception..
              //label1.text = ex.Message;
              }
         }
    }
}
 

Does it give error message? 

You could try to dispose objects after you send.

Also make sure email addresses are correct, you are inserting '[email protected]', it might be 'orders@ultimatelights.com.au' 

 Ideally, it should work with for loop too, but there is no need.. 

Hi Ali, I tried the amendments below and it's still only sending to the first SuppEmail not the second. Is there anything else I could try.

using System;
using System.Collections.Generic;
using System.Data;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data.SqlClient;
using System.Net;
using System.Net.Mail;
using System.Text;

namespace SpecCars.Admin
{
  public partial class Trying2 : System.Web.UI.Page
  {
    protected void Page_Load(object sender, EventArgs e)
    {

    }

    protected void Button1_Click(object sender, EventArgs e)
    {

      SqlDataReader sqlData;
      SqlConnection connection = new SqlConnection("Data Source=.;Initial Catalog=SpecCars;Integrated Security=True");

      connection.Open();
      sqlData = new SqlCommand("Select SuppEmail From Suppliers", connection).ExecuteReader();

     // int count = sqlData.FieldCount;

      while (sqlData.Read())
      {
       // for (int i = 0; i < count; i++)
       // {
          string emailnew = sqlData["SuppEmail"].ToString();

          MailMessage mailMessage = new MailMessage();

          mailMessage.From = new MailAddress("myemail.com");
         // mailMessage.To.Add("myemail.com");
          mailMessage.To.Add(emailnew);
          //mailMessage.CC.Add(emailnew);
          mailMessage.Subject = "Assembly Line Stop";
          mailMessage.Priority = MailPriority.High;

          mailMessage.Body = "Please be advised that the assembly line at Specialised Cars has STOPPED. You will be notified once the line has started again. Any Services between the LINE STOP and the LINE START will be carried out after 19:00 (7pm).";
          mailMessage.IsBodyHtml = true;

          SmtpClient smtpClient = new SmtpClient("smtp-mail.myprovider.com", 587);
          smtpClient.EnableSsl = true;
          smtpClient.Credentials = new System.Net.NetworkCredential("myemail.com", "password");
          smtpClient.Send(mailMessage);
        }
      connection.Close();
      }
   
    }

  }
 

}
connection.Close();