Random question

Question

I am using the following code to create random passwords (not my code) public static string RandomPassword(int PasswordLength) { string _allowedChars = "ACDEFGHJKLMNPQRTWXYZ12345679"; Byte[] randomBytes = new Byte[PasswordLength]; char[] chars = new char[PasswordLength]; int allowedCharCount = _allowedChars.Length; Random randomObj = new Random(); for(int i = 0;i<PasswordLength;i++) { randomObj.NextBytes(randomBytes); chars[i] = _allowedChars[(int)randomBytes[i] % allowedCharCount]; } return new string(chars); } Whenever I use this code more than once on my page with the same length I get the same result. But if I use a different length I get the same first character and the rest different. Could someome please help explain what is happening, because I dont understand this code.

jcity444 · Answer

Not sure exactly what's happening, but you should seed your random generator, but keep in mind the Random class is a pseudo random number generator which means it can generate predictable results with the same seed. Try constructing your random number generator with a dynamicly changing seed as shown below: e.g. Random randomObj = new Random((int) DateTime.Now.Ticks); -Mike G.

Random question

Answers (1)