Return value from function to ActionMethod in controller

Anan Srivastava

[HttpPost]
public ActionResult AddVolunteer(VolunteerInfo viewModel)
{
if (!ModelState.IsValid)
{
return View("AddVolunteer", viewModel);
}
var volunteer = new VolunteerInfo()
{
Name = viewModel.Name,
DonationForWhom = DonationValue() //Here's the error. Expecting a parameter
};
_context.VolunteerInfos.Add(volunteer);
_context.SaveChanges();
return RedirectToAction("Index", "Home");
}
public string DonationValue(string name)
{
return name; //not sure how to pass this above
}

The error is in the 12th line: There is no argument given that corresponds to the required formal parameter 'name' of 'VolunteerInfoController.DonationValue(string)' VMS.

I don't know how to correct this. Please help me

14 Replies

Know the answer? Post it — somebody with the same question will find it here.

Ruchi Sharavat8y ago
Firstly, you are changing your problem and scenario with every reply. Please do not do that and show all of your code at once including C#,Html and JQuery.

Now why are you calling ajax to call function "DonationValue" while you are already calling that in C# within your "AddVolunteer" method?

If you are hiding/showing textboxed on radio button change and it's working for you than you can just perform show/hide using radio button but at the same time you are making ajax call that doesn't make sense because radio button change will show the textbox and that would be empty first of all.

Is the radiobutton is any property of your viewmodel VolunteerInfo ? If so you can just check that in your code, if that is true pass viewmodel.Donation as parameter otherwise viewmodel.GetNames?

Still not clear than share full code.
Anan Srivastava8y ago
Thanks for replying Ruchi. I don't quite understand what you're trying to say. That's because I am a beginner as evident from my rank. This is my script in the View
"text/javascript">

    $(document).ready(function () {
        $('#Donation').hide();  //Donation is the Id of the text box

        $('input[ type ="Radio"]').on('click', function() {
            if ($(this).val() == 'No') {  //this here represents radio button
                $('#Donation').show();
                if ($('#Donation').val() !== null) {

                    $.ajax({
                        url: '@Url.Action("DonationValue","VolunteerInfo")',
                        data: { name: $("#Donation").val() },
                        type: "POST"
                    });
                }
                else alert("Please enter who the Donation is for");

            }
            else {
                $('#Donation').hide();
                $.ajax({
                    url: '@Url.Action("DonationValue","VolunteerInfo")',
                    data: { name: $("#GetNames").val() },
                    type: "POST"
                });
            }
        });

    });
So what I am doing here is, if the user clicks on No RadioButton, I show a text box where he/she can enter a name. If the radio button checked is yes, I am getting data from another textbox whos ID is #GetNames. What changes I need to make here?
Ruchi Sharavat8y ago
The error will get resolved definitely by passing an srgument to your function but the logic for the situation you are facing that parameter name is not fixed. You can do:

1. Take a new property in your viewmodel with any name like - "DonationForWhomprop" and set its value in view when you change checkbox selection. It must have the value according to the checbox selection. On the code side always pass this property as parameter to your function. you can take this property in your view of type hidden and set it's value on onchange of your checkboxes.
[HttpPost]
        public ActionResult AddVolunteer(VolunteerInfo viewModel)
        {
            if (!ModelState.IsValid)
            {
                return View("AddVolunteer", viewModel);
            }

            var volunteer = new VolunteerInfo()
            {
                Name = viewModel.Name,
                DonationForWhom = DonationValue(viewModel.DonationForWhomprop) //Here's the error. Expecting a parameter

            };


            _context.VolunteerInfos.Add(volunteer);
            _context.SaveChanges();
            return RedirectToAction("Index", "Home");

        }

OR
2. Add switch case in code to find which parameter you need to pass your function based on checkbox value and pass that parameter to your fucntion.
Anan Srivastava8y ago
That would have been a perfect solution except, I can't do that. My value in the view is changing based on the checkbox checked. For example, if checkbox A is checked, I am passing a name from different textbox (let's assume textbox A) and if checkbox B is checked, I am passing value from another textbox (textbox B). That's why I have tweaked the code in View in such a way that 'name' parameter in DonationValue function will get the correct value based on the checkbox checked.

If I simply pass the viewModel."My Parameter" , I will not get what I want. I will just get one value irrespective of the the checkbox checked.

That;s why I can't do that.
Jenith Thakkar8y ago
Okay!

Then Just pass that parameter directly from Viewmodel
var volunteer = new VolunteerInfo()
{
Name = viewModel.Name,
DonationForWhom = DonationValue(Viewmodel."Your Parameter") //Here's the error. Expecting a parameter
};
Check this and if this works then approve my answer
Anan Srivastava8y ago
Yes I am able to understand you. And yes that's what I want. Excatly what you said.
Jenith Thakkar8y ago
Okay Are you pass that value in VolunteerInfo viewModel

From View which you want use in DonationForWhom

If Yes then you need to pass that value as a parameter?

So it will return from
public string DonationValue(string abc)
{
return abc; //not sure how to pass this above
}
Are you able to understand what i'm trying to say?
Anan Srivastava8y ago
In the below function, I am getting a value from my view. I want to store that value in my DB.
public string DonationValue(string abc)
{
return abc; //not sure how to pass this above
}
So the AddVolunteer POST method is written to get all the values from the View and store in DB. The name of the doner is going in the column DonationForWhom. That's why I am trying this.
Jenith Thakkar8y ago
Okay I will Explain you in Detail First You tell me what do you want in DonationForWhom

So Based on that i will tell you solution
Anan Srivastava8y ago
I know I need to pass a parameter. But what is that parameter?
Anan Srivastava8y ago
How will passing the parameter "Test" help me? Will my actual value overwrite this "Test" parameter and save in the DB? Thanks.
Jenith Thakkar8y ago
Yes I understand what do you want to ask

Just You need to pass Parameter DonationValue
var volunteer = new VolunteerInfo()
{
Name = viewModel.Name,
DonationForWhom = DonationValue("Test") //Here's the error. Expecting a parameter
};
Because you have created Function is Parametarise "string abc"
public string DonationValue(string abc)
{
return abc; //not sure how to pass this above
}
So it will not allow "DonationForWhom=DonationValue();"
Anan Srivastava8y ago
Hi Jenith. Thank you for replying. Maybe I wasn't clear enough, but viewModel.Name and the 'name' in the function are different. Passing viewModel.Name will give me a different value than what I am expecting. Please see below, I have edited is slightly. I want to pass string abc to line 12
[HttpPost]
        public ActionResult AddVolunteer(VolunteerInfo viewModel)
        {
            if (!ModelState.IsValid)
            {
                return View("AddVolunteer", viewModel);
            }

            var volunteer = new VolunteerInfo()
            {
                Name = viewModel.Name,
                DonationForWhom = DonationValue() //Here's the error. Expecting a parameter

            };


            _context.VolunteerInfos.Add(volunteer);
            _context.SaveChanges();
            return RedirectToAction("Index", "Home");

        }



        public string DonationValue(string abc)
        {
            return abc; //not sure how to pass this above
        }
Jenith Thakkar8y ago
You need to pass parameter value when you call another parameterise method like below

Name = viewModel.Name,
DonationForWhom = DonationValue(viewModel.Name);

Based on Above Example It will return Test