Try to pass model in ViewModel into the Detail action

osyris zosar

5y867Learn iOS Programming

If have created a Viewmodel:

public async Task Details(Guid? id)
{
if (id == null)
{
return NotFound();
}
ProductDetailViewModel productview = new ProductDetailViewModel()
{
productImages = await _context.ProductImages.FirstOrDefaultAsync( c => c.ProductId == id), //error
productWithImagesDbs = await _context.ProductWithImagesDb.FirstOrDefaultAsync(m=> m.ProductId == id) // error
};
if (productview == null)
{
return NotFound();
}
return View(productview);
}

the viewmodel:

public class ProductDetailViewModel
{
public List productWithImagesDbs { get; set; }
public List productImages { get; set; }
}

the model:

public class ProductImages
{
[Key]
[Required]
public Guid ProductId { get; set; }
[Required]
public string ImagePath { get; set; }
[Required]
public int ImageOrder { get; set; }
}

public class ProductWithImages
{
[Key]
[Required]
public Guid ProductId { get; set; }
[Required]
[Display(Name ="Product Title")]
public string ProductTitle { get; set; }
// etc...

Its probaly something really simple that i dont know about yet. but i can seem to figure it out

it gives the error : Cannot implicitly convert type Test4.Models.ProductImagesDb to System.Collections.Generics.List

6 Replies

Know the answer? Post it — somebody with the same question will find it here.

Rijwan Ansari5y ago
Accepted answer
Hi,
I can observe that you are selecting first or default which return single value. However, your viewModel is having list as properties.
Update your viewModels action as
public class ProductDetailViewModel
{
    public ProductWithImagesDb productWithImagesDb { get; set; } //based on your model
    public ProductImages productImage { get; set; } // based on your model
}
Then you controller actions as
public async Task Details(Guid? id)
    {

        if (id == null)
        {
            return NotFound();
        }
        ProductDetailViewModel productview = new ProductDetailViewModel()
        {
           productImage = await _context.ProductImages.FirstOrDefaultAsync( c => c.ProductId == id),
           productWithImagesDb = await _context.ProductWithImagesDb.FirstOrDefaultAsync(m=> m.ProductId == id)

        };

        if (productview == null)
        {
            return NotFound();
        }
        return View(productview);
    }
Try this and let us know the result.

Regards
Rijwan
osyris zosar5y ago
Thank you so much as Satya Karki said I was trying to use a list in viewmodel and return a single value.
the code looks much cleaner and I understand it much beter now.

Thank you so much!
Satya Karki5y ago
Hi,

Please check your viewModel, it is using list and your query in controlller is returning single value.
Modify your viewModels
public class ProductDetailViewModel
{
    public ProductWithImagesDb productWithImagesDbs { get; set; }
    public ProductImages productImages { get; set; }
}
osyris zosar5y ago
I have no clue how the hell i achived it but it worked.

controller action:
public async Task Details(Guid? id)
     {

         if (id == null)
         {
             return NotFound();
         }

         var pr1 = from m in _context.ProductImages
                     select m;


         var pr2 = from m in _context.ProductWithImagesDb
                   select m;

         var productview = new ProductDetailViewModel();
         productview.productImages = await pr1.Where(x => x.ProductId.Equals(id)).Select(x => new ProductImages
         {
             ProductId = x.ProductId,
             ImagePath = x.ImagePath,
             ImageOrder = x.ImageOrder
         }).ToListAsync();

         productview.productWithImagesDbs = await pr2.Where(x => x.ProductId.Equals(id)).Select(x => new ProductWithImagesDb
         {
             ProductId = x.ProductId,
             ProductTitle = x.ProductTitle,
             ProductDiscription = x.ProductDiscription,
             Price = x.Price,
             quantity = x.quantity,
             HeaderImage = x.HeaderImage

         }).ToListAsync();


         if (productview.productImages == null || productview.productWithImagesDbs == null)
         {
             return NotFound();
         }
         return View(productview);
     }
the view:
@model Test4.ViewModels.ProductDetailViewModel

@{
    ViewData["Title"] = "Details";
    Layout = "~/Views/Shared/_Layout.cshtml";
}

<h1>Detailsh1>
@foreach (var item in Model.productWithImagesDbs)
{
    <div>
        <h4>ProductWithImagesDbh4>
        <hr />
        <dl class="row">

            <dt class="col-sm-2">
                @Html.DisplayNameFor(model => model.productWithImagesDbs[0].ProductTitle)

            dt>
            <dd class="col-sm-10">
                @Html.DisplayFor(x => item.ProductTitle)

            dd>
            <dt class="col-sm-2">
                @Html.DisplayNameFor(model => model.productWithImagesDbs[0].ProductDiscription)
            dt>
            <dd class="col-sm-10">
                @Html.DisplayFor(x => item.ProductDiscription)
            dd>
            <dt class="col-sm-2">
                @Html.DisplayNameFor(model => model.productWithImagesDbs[0].Price)
            dt>
            <dd class="col-sm-10">
                @Html.DisplayFor(x => item.Price)
            dd>
        dl>
    div>

    <div>
        <a asp-action="Edit" asp-route-id="@Html.DisplayFor(x=> item.ProductId)">Edita> |
        <a asp-action="Index">Back to Lista>
    div>
}
I feel like this might not be the best way to approach this but i dont know
could this be coded beter?
Sachin Singh5y ago
public async Task Details(Guid? id)
    {

        if (id == null)
        {
            return NotFound();
        }
    var pImg= await _context.ProductImages.FirstOrDefaultAsync( c => c.ProductId == id);
var pwImg= await _context.ProductWithImagesDb.FirstOrDefaultAsync(m=> m.ProductId == id) ;
        ProductDetailViewModel productview = new ProductDetailViewModel()
        {
           productImages =pImg,
           productWithImagesDbs =pwImg

        };

        if (productview == null)
        {
            return NotFound();
        }
        return View(productview);
    }
Suraj Dubey5y ago
Hi,

try this it will help you

https://stackoverflow.com/questions/28632103/cannot-implicitly-convert-type-to-system-collections-generic-list