Two forms, labels do not update

Fabio Santos

Hi, I'm having a hard time trying to figure out this: I have a program which has two forms: mainForm and statsForm. I collect data in the main form through buttons and then I click on the statsButton and the statsForm opens. The thing is: If I click the statsButton, the statsForm opens up with updated data, but if I leave it open and continues to use the mainForm, it does not update the labels in the statsForm. It is suppose to update, refresh or whatever every 5 seconds. I've tried this:
public StatsForm()
{
InitializeComponent();
RefreshTimer.Interval = 1000 * 1; //5 seconds
RefreshTimer.Tick += new EventHandler(RefreshTimer_Tick);
RefreshTimer.Enabled = true;
}

private void RefreshTimer_Tick(object sender, EventArgs e)
{
this.Refresh();
}

I tried update, Invalidate and it does not work. I checked and the variables within the statsForm update its values but it does not update update the label assigned to it. How can I make it work?

3 Replies

Know the answer? Post it — somebody with the same question will find it here.

Sam Hobbs15y ago
What happens when mainForm changes the data?

To do the update, you essentially need to re-execute (or do the equivalent of) "statsForm.AceSet1Player1 = aceSet1Player1;" and the other lines. I assume (and if I am wrong then you still have not provided essential information) that you expect "this.Refresh();" to do that. The Refresh will simply use the current value of the data that is in that instance of statsForm; it will not get the data from mainForm.

So what I would do is to do the update of the data in mainForm. You can put "statsForm.AceSet1Player1 = aceSet1Player1;" and related lines in a public function in statsForm and then call that function from mainForm. I assume that there is something that mainForm is doing to update the data that is in it and I would call the update function from there instead of using a timer. There are alternatives for doing what you are doing but I think this is the best balance of simplicity for you as a beginner and use of object-oriented design.
Fabio Santos15y ago
Thanks for replying Sam. They are labels because I just want the numbers to appear in the form rather than the whole textbox. Well, I use intergers variables to store all the data I want to. All the data is stored first in the mainForm, then I call the statsForm pushing the stats button, so it opens up. The way I put the data into the statsForm follow below:

//Open the stats form
private void statsButton_Click(object sender, EventArgs e)
{
//Initialize the stats form.
StatsForm statsForm = new StatsForm();

//Declare variables for serve.
//Ace
statsForm.AceSet1Player1 = aceSet1Player1;
statsForm.AceSet2Player1 = aceSet2Player1;
statsForm.AceSet3Player1 = aceSet3Player1;
statsForm.AceSet1Player2 = aceSet1Player2;
statsForm.AceSet2Player2 = aceSet2Player2;
statsForm.AceSet3Player2 = aceSet3Player2;

statsForm.Show();

Then I give the variables in the statsForm, the same name as in the mainForm. Got it?
Ah, one more thing, I tried using textBox instead of labels and the result was the same.
I really appreciate your help!!!
Thanks!
Sam Hobbs15y ago
Are they labels or are they textboxes? If they are textboxes then please call them textboxes. Labels are usually used in a manner that do not need to be changed.

You don't tell us what variables are used for the data in terms of where they are. You don't tell us how the data is put into the statsForm. You need to tell us more.