Weird issues when adding to a winform listbox

Scott G

I have an application that allows the user to select a file and display the folder\filename in a listbox. The problem I am having is when it adds it to the listbox it adds a blank row above it. This is causing a second row to be created in the database with this field being blank. This only happens though with the first file selected. If I go back to add another one it does not add the blank row. It also does not happen if I select multiple files at once to add. In addition to that if I minimize then maximize the application any items listed in the listbox are duplicated.

private void btnModSel_Click(object sender, EventArgs e)
{
System.IO.Stream myStream;
OpenFileDialog openFiledialog1 = new OpenFileDialog();
openFiledialog1.FilterIndex = 2;
openFiledialog1.InitialDirectory = "P:\\Folder\\subfolder";
openFiledialog1.RestoreDirectory = true;
openFiledialog1.Multiselect = true;
openFiledialog1.Title = "Please Select a File";
if (openFiledialog1.ShowDialog() == DialogResult.OK)
{
foreach (String file in openFiledialog1.FileNames)
{
try
{
if ((myStream = openFiledialog1.OpenFile()) != null)
{
using (myStream)
{
lstModFiles.Items.Add(file.Substring(52));
}
}
}
catch (Exception ex)
{
MessageBox.Show("Error: Could not read file from disk. Original error: " + ex.Message);
}
}
}
}

7 Replies

Know the answer? Post it — somebody with the same question will find it here.

Rafnas T P7y ago
hi,

its good if you clear the list before adding list,

so before foreach loop just clear your list as below

lstModFiles.Items.Clear();
Scott G7y ago
I kept saying maximize which is not correct. It is happening when I restore the minimized app from the taskbar.
Scott G7y ago
Anyone have any other suggestions?
Scott G7y ago
I take that back. It is still adding the item multiple times to the listbox when I minimize/maximize.
Amit Gupta7y ago
Can you try clean and rebuild your project or try upgrading the .net framework. I hear this weird first time. Do try and let me know or share some screenshots
Scott G7y ago
Not real experienced with C#. I am kind of learning as I go.
That being said it doesnt look like it likes file.FileName so I used

string filename = Path.GetFileName(file)
lstModFiles.Items.Add(filename)

I am not noticing the issue when I minimize/maximize but it is still adding the blank line before the file in the listbox.
Amit Gupta7y ago
Why using substring as 52, if you want to add just filename then file.FileName will be used.