when i am executing getting an error incorrect syntax near

Bobi B

9y1kLearn iOS Programming

using System;

using System.Data;

using System.Configuration;

using System.Collections;

using System.Web;

using System.Web.Security;

using System.Web.UI;

using System.Web.UI.WebControls;

using System.Web.UI.WebControls.WebParts;

using System.Web.UI.HtmlControls;

using System.Data.SqlClient;

public partial class forms : System.Web.UI.Page

{

public static string str = @"Data Source=(LocalDB)\v11.0;AttachDbFilename=|DataDirectory|\ChitFund-DataBase.mdf;Integrated Security=True";

SqlConnection con = new SqlConnection(str);

SqlDataAdapter adpt = new SqlDataAdapter();

protected void Page_Load(object sender, EventArgs e)

{

regdate.Text = DateTime.Now.ToString("dd/MM/yyyy");

}

protected void Button2_Click(object sender, EventArgs e)

{

SqlCommand cmdinser = new SqlCommand("insert into ChitFund-CustomerRegistration values('" + id.Text + "' , '" + name.Text + "','" + father.Text + "' , '" + DropDownList1.Text + "','" + occupation.Text + "','" + dob.Text + "' , '" + regdate.Text + "','" + phone.Text + "' , '" + aadhar.Text + "','" + email.Text + "','" + address.Text + "','" + pincode.Text + "','" + area.Text + "','" + district.Text + "','" + street.Text + "','" + state.Text + "','" + offname.Text + "','" + offaddress.Text + "','" + offstreet.Text + "','" + offpin.Text + "','" + offdistrict.Text + "','" + offstate.Text + "','" + nomname.Text + "','" + nomrelation.Text + "','" + nomphonenumber.Text + "','" + nomaddress.Text + "','" + nompincode.Text + "','" + nomdistrict.Text + "','0')", con);

cmdinser.CommandType = CommandType.Text;

adpt.SelectCommand = cmdinser;

DataTable dt = new DataTable();

adpt.Fill(dt);

ClientScript.RegisterStartupScript(this.GetType(), "s", "alert('Registered Successfully')", true);

}

4 Replies

Know the answer? Post it — somebody with the same question will find it here.

Bryian Tan9y ago
You should update the code to wrap the table name ChitFund-CustomerRegistration with brackets [ChitFund-CustomerRegistration]

Further more, once you got everything working, take a look at the Parameterized Query https://msdn.microsoft.com/library/bb738521(v=vs.100).aspx
Amit Gupta9y ago
@Bobi

Few things to be consider in this regard
1. Code must be optimised, as it was poorly written and always complicate the situation to find errors and hard to maintain

You may write the query like
var query  = "insert into tableName (name) values (@name)";
var command = new SqlCommand(query, connection);
command.Parameters.AddWithValue("@name", txtName.Text);

// pass connection to command
command.ExecuteNonQuery ();
You can insert with or without column name but it should be better to insert it with columnNames.

2. Donot convert DateTime.Now() to dd/mm/yyyy, pass the date time as it is, if still needed use the global format "yyyy-MM-dd" ( as seen in regDate.Text).

Coming to your question, there might be syntax error in the insert query, just need to put a breakpoint and get the value and paste the value to ssms, you will get the solution there itself.

Hope this helps
Rajeev Punhani9y ago
Hi Bobi,

I think you are getting error near DropDownList1.Text.Please use SelectedItem.Text or DropDownList1.SelectedValue.If not please post complete error message.
DropDownList1.SelectedItem.Text
Atul Rokade9y ago
you forget to specify column name
new SqlCommand("insert into ChitFund-CustomerRegistration('id','name','father' so on...) values('" + id.Text + "' , '" + name.Text + "','" + father.Text + "' , '" + DropDownList1.Text + "','" + occupation.Text + "','" + dob.Text + "' , '" + regdate.Text + "','" + phone.Text + "' , '" + aadhar.Text + "','" + email.Text + "','" + address.Text + "','" + pincode.Text + "','" + area.Text + "','" + district.Text + "','" + street.Text + "','" + state.Text + "','" + offname.Text + "','" + offaddress.Text + "','" + offstreet.Text + "','" + offpin.Text + "','" + offdistrict.Text + "','" + offstate.Text + "','" + nomname.Text + "','" + nomrelation.Text + "','" + nomphonenumber.Text + "','" + nomaddress.Text + "','" + nompincode.Text + "','" + nomdistrict.Text + "','0')", con);