Why code return false value when username and password are correct?

Inderjeet Kaur

class Student : DbConnection

{

public string stud_Username { set; get; }

public string stud_Password { set; get; }

public bool verify_User()

{

connectDb.Open();

SqlDataReader rd;

bool check = false;

using (var cmd = new SqlCommand())

{

cmd.CommandText = "SELECT * FROM stud_Login_Table WHERE Username=@user AND Password=@pass";

cmd.CommandType = CommandType.Text;

cmd.Connection = connectDb;

cmd.Parameters.Add("@user", SqlDbType.VarChar).Value = stud_Username;

cmd.Parameters.Add("@pass", SqlDbType.VarChar).Value = stud_Password;

rd = cmd.ExecuteReader();

while (rd.Read())

{

MessageBox.Show("Connected to database..");

}

connectDb.Close();

}

return check;

}

DbConnection conn = new DbConnection();

Student stud = new Student();

private void loginButton_Click(object sender, EventArgs e)

{

stud.stud_Username= studUser.Text;

stud.stud_Password = studPass.Text;

bool verify = stud.verify_User();

if (verify==true)

{

MessageBox.Show(" Logged in ");

Home home = new Home();

home.Show();

this.Hide();

}

else

{

MessageBox.Show("Check your Username and password !!");

}

2 Replies

Know the answer? Post it — somebody with the same question will find it here.

Salman Beg5y ago
Accepted answer
In the verify_User() method you declared bool check = false; but after that in the same method you didn't updated check value to true. Inside the while loop you are showing a message and in that same loop update check=true; then run your code. Thanks
Rijwan Ansari5y ago
Hi indeerjeet

Try this code for verify_user as shown
public bool verify_User()
{
connectDb.Open();
SqlDataReader rd;
bool check = false;
using (var cmd = new SqlCommand())
{
cmd.CommandText = "SELECT * FROM stud_Login_Table WHERE Username=@user AND Password=@pass";
cmd.CommandType = CommandType.Text;
cmd.Connection = connectDb;
cmd.Parameters.Add("@user", SqlDbType.VarChar).Value = stud_Username;
cmd.Parameters.Add("@pass", SqlDbType.VarChar).Value = stud_Password;
rd = cmd.ExecuteReader();
while (rd.Read().Count > 0)
{
//MessageBox.Show("Connected to database..");
check = true;
}
connectDb.Close();
}
return check;
}
Try now and let us know you result.
Regards
Rijwan