login code not working

Subin Thomas

7y1.4k.NET

i have a login table which contains userid username password lastvisited and so on i wrote a code for login but its not working below is the code

and also the password is not visible in the database its encrypted

using System;
using System.Collections.Generic;
using System.Linq;
using System.Web;
using System.Web.UI;
using System.Web.UI.WebControls;
using System.Data;
using System.Data.SqlClient;
using System.Configuration;
using System.IO;
using System.Security.Cryptography;
namespace Vas
{
public partial class CostMonitoring : System.Web.UI.Page
{
public static string con_Vas = ConfigurationManager.ConnectionStrings["vas_con"].ConnectionString;
SqlConnection condiv = new SqlConnection(con_Vas);
protected void Page_Load(object sender, EventArgs e)
{
}
protected void btnLogin_Click(object sender, EventArgs e)
{
string strSelect = "SELECT COUNT(*) FROM VAS_Login WHERE UserID = @Username AND Password = @Password";
SqlConnection con = new SqlConnection(con_Vas);
SqlCommand cmd = new SqlCommand("Vas_adminvas_login", con);
cmd.CommandType = CommandType.StoredProcedure;
//SqlCommand cmd = new SqlCommand();
cmd.Connection = con;
cmd.CommandType = CommandType.Text;
cmd.CommandText = strSelect;
SqlParameter username = new SqlParameter("@Username", SqlDbType.NVarChar, 50);
username.Value = txtusername.Text.Trim().ToString();
cmd.Parameters.Add(username);
SqlParameter password = new SqlParameter("@Password", SqlDbType.NVarChar, 100);
password.Value =(txtpass.Text.Trim());
cmd.Parameters.Add(password);
// cmd.CommandTimeout = 1000;
con.Open();
int result = (Int32)cmd.ExecuteScalar();
con.Close();
if (result >= 1)
{
Response.Redirect("www.google.com");
}
else
{
Label1.Text = "incorrect password or username";
}
}
}
}

7 Replies

Know the answer? Post it — somebody with the same question will find it here.

Sanwar Ranwa7y ago
Accepted answer
1. string strSelect = "SELECT COUNT(*) FROM VAS_Login WHERE UserID = @Username AND Password = @Password";
3. SqlConnection con = new SqlConnection(con_Vas);
4. SqlCommand cmd = new SqlCommand();
5. cmd.Connection = con;
6. cmd.CommandType = CommandType.Text;
7. cmd.CommandText = strSelect;
9. SqlParameter username = new SqlParameter("@Username", SqlDbType.NVarChar, 50);
10. username.Value = txtusername.Text.Trim().ToString();
11. cmd.Parameters.Add(username);
13. SqlParameter password = new SqlParameter("@Password", SqlDbType.NVarChar, 100);
14. password.Value =(txtpass.Text.Trim());
15. cmd.Parameters.Add(password);
16. // cmd.CommandTimeout = 1000;
18. con.Open();
19. int result = (Int32)cmd.ExecuteScalar();
20. con.Close();
22. if (result >= 1)
23. {
25. Response.Redirect("www.google.com");
26. }
27. else
28. {
29. Label1.Text = "incorrect password or username";
30. }
34. }
35. }
36. }

Sanwar Ranwa7y ago

https://www.c-sharpcorner.com/blogs/how-to-encrypt-or-decrypt-password-using-asp-net-with-c-sharp1

https://www.aspsnippets.com/Articles/Encrypt-and-Decrypt-Username-or-Password-stored-in-database-in-ASPNet-using-C-and-VBNet.aspx

Subin Thomas7y ago

Sanwar Ranwa yes its working when i put dummy data without any encryption can you tell me how to apply encryption

Sanwar Ranwa7y ago

yes and you can also check by adding a demo password in your database table

Subin Thomas7y ago

Sanwar Ranwa thank you so much fo the code changes i executed it but still it is saying incorrect pasword the password is encrypted so we need to encrypt the password right ??

Subin Thomas7y ago

Salman Beg yea i just noticed

Salman Beg7y ago

Hi. You are using both stored procedure as well as inline query. Either use stored procedure or inline query. You can put breakpoint as well as try catch block to check for errors. Thanks.